eric-maynard commented on code in PR #435:
URL: https://github.com/apache/polaris/pull/435#discussion_r1833443142
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/MetaStoreManagerFactory.java:
##########
@@ -33,7 +32,7 @@
* configuration
*/
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY,
property = "type")
-public interface MetaStoreManagerFactory extends Discoverable {
Review Comment:
My understanding is that removing Discoverable from this will break any
implementations that want to supply their own configs (I think that's the
polymorphic configuration mentioned above?).
If you can provide such an implementation in a test and the configs still
get picked up, I think we would be good to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
