singhpk234 commented on code in PR #442:
URL: https://github.com/apache/polaris/pull/442#discussion_r1835546848


##########
polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -2055,8 +2054,6 @@ private List<TableIdentifier> 
listTableLike(PolarisEntitySubType subType, Namesp
    */
   private FileIO loadFileIO(String ioImpl, Map<String, String> properties) {
     Map<String, String> propertiesWithS3CustomizedClientFactory = new 
HashMap<>(properties);
-    propertiesWithS3CustomizedClientFactory.put(
-        S3FileIOProperties.CLIENT_FACTORY, 
PolarisS3FileIOClientFactory.class.getName());

Review Comment:
   Might have to mark this deprecated first since it's a public class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to