collado-mike commented on code in PR #442:
URL: https://github.com/apache/polaris/pull/442#discussion_r1841397103
##########
polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -2055,8 +2054,6 @@ private List<TableIdentifier>
listTableLike(PolarisEntitySubType subType, Namesp
*/
private FileIO loadFileIO(String ioImpl, Map<String, String> properties) {
Map<String, String> propertiesWithS3CustomizedClientFactory = new
HashMap<>(properties);
- propertiesWithS3CustomizedClientFactory.put(
- S3FileIOProperties.CLIENT_FACTORY,
PolarisS3FileIOClientFactory.class.getName());
Review Comment:
I think it was only ever used for this purpose, so we're probably fine
##########
polaris-service/src/test/java/org/apache/polaris/service/PolarisApplicationIntegrationTest.java:
##########
@@ -341,7 +341,7 @@ public void testIcebergListNamespacesNestedNotFound()
throws IOException {
sessionCatalog.listNamespaces(
sessionContext, Namespace.of("top_level", "whoops")))
.isInstanceOf(NoSuchNamespaceException.class)
- .hasMessage("Namespace does not exist: top_level.whoops");
+ .hasMessage("Namespace does not exist: top_level%1Fwhoops");
Review Comment:
Is this the response in the error message now? I think the dot in the error
is much more user friendly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
