collado-mike commented on code in PR #438:
URL: https://github.com/apache/polaris/pull/438#discussion_r1838515895
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##########
@@ -701,9 +701,9 @@ public int lookupEntityGrantRecordsVersion(
principalSecrets.getPrincipalId());
// rotate the secrets
- principalSecrets.rotateSecrets(mainSecretToRotate);
+ principalSecrets.rotateSecrets();
if (reset) {
- principalSecrets.rotateSecrets(principalSecrets.getMainSecret());
Review Comment:
Hmm, the reason we passed in the original secret was for idempotence. It's
imperative to make sure that if a rotate request is sent twice accidentally
(e.g., client retry), the keys aren't rotated twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
