eric-maynard commented on code in PR #438:
URL: https://github.com/apache/polaris/pull/438#discussion_r1833577538
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrincipalSecrets.java:
##########
@@ -108,11 +155,29 @@ public String getPrincipalClientId() {
return principalClientId;
}
+ public boolean matchesSecret(String potentialSecret) {
+ String potentialSecretHash = hashSecret(potentialSecret);
+ return potentialSecretHash.equals(this.mainSecretHash)
+ || potentialSecretHash.equals(this.secondarySecretHash);
Review Comment:
+1, I am not clear on this. I put a note in the description, but I basically
copied what I saw as the existing behavior. I am open to keeping/changing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
