dimas-b commented on code in PR #457:
URL: https://github.com/apache/polaris/pull/457#discussion_r1847411490
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizableOperation.java:
##########
@@ -121,6 +122,7 @@ public enum PolarisAuthorizableOperation {
CREATE_CATALOG(CATALOG_CREATE),
GET_CATALOG(CATALOG_READ_PROPERTIES),
UPDATE_CATALOG(CATALOG_WRITE_PROPERTIES),
+ UPDATE_CATALOG_MAINTENANCE_PROPERTIES(CATALOG_WRITE_MAINTENANCE_PROPERTIES),
Review Comment:
tangential: This change LGTM, but I'm thinking about braking down the
operation enum into several enums with dedicated scope (operations within a
catalog, catalog management (add/remote), ermission management)... Just FYI :)
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisPrivilege.java:
##########
@@ -102,7 +102,9 @@ public enum PolarisPrivilege {
CATALOG_ROLE_FULL_METADATA(67, PolarisEntityType.CATALOG_ROLE),
CATALOG_ROLE_MANAGE_GRANTS_ON_SECURABLE(68, PolarisEntityType.CATALOG_ROLE),
CATALOG_ROLE_MANAGE_GRANTS_FOR_GRANTEE(69, PolarisEntityType.CATALOG_ROLE),
- ;
Review Comment:
nit: keeping this semicolon on a new line allows for pure "add" diffs in PRs
and simplifies linking enum values to commits that truly added them :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
