adutra commented on code in PR #457: URL: https://github.com/apache/polaris/pull/457#discussion_r1848541843
########## polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisMaintenanceProperties.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.entity; + +import static org.apache.polaris.core.entity.PolarisEntityConstants.MAINTENANCE_PREFIX; + +public enum PolarisMaintenanceProperties { + COMPACTION(MAINTENANCE_PREFIX + "compaction"), + SNAPSHOT_RETENTION(MAINTENANCE_PREFIX + "snapshot_expiration"); + + private final String value; Review Comment: the name `value` is misleading, it's rather the property _name_. ########## polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisMaintenanceProperties.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.entity; + +import static org.apache.polaris.core.entity.PolarisEntityConstants.MAINTENANCE_PREFIX; + +public enum PolarisMaintenanceProperties { + COMPACTION(MAINTENANCE_PREFIX + "compaction"), + SNAPSHOT_RETENTION(MAINTENANCE_PREFIX + "snapshot_expiration"); + + private final String value; + + PolarisMaintenanceProperties(String value) { + this.value = value; + } + + public String getValue() { + return value; + } + + public static PolarisMaintenanceProperties fromValue(String value) { Review Comment: What is the added value of this method, as opposed to `PolarisMaintenanceProperties.valueOf()`? ########## polaris-core/src/main/java/org/apache/polaris/core/entity/PolarisMaintenanceProperties.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.entity; + +import static org.apache.polaris.core.entity.PolarisEntityConstants.MAINTENANCE_PREFIX; + +public enum PolarisMaintenanceProperties { + COMPACTION(MAINTENANCE_PREFIX + "compaction"), + SNAPSHOT_RETENTION(MAINTENANCE_PREFIX + "snapshot_expiration"); Review Comment: Also, the enum name says `RETENTION` but the property has `expiration` – would be good to standardize. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
