eric-maynard commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1852673738
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -181,6 +196,19 @@ private PrincipalSecretsResult
bootstrapServiceAndCreatePolarisPrincipalForRealm
throw new IllegalArgumentException(overrideMessage);
}
+ // TODO rebase onto #422, call a method like
PrincipalSecretsGenerator.hasEnvironmentVariables
Review Comment:
I like that idea. If there is a good pathway from the bootstrap command down
to the `PrincipalSecretsGenerator` then I think that works as well. It should
hopefully be more clear when #422 merges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
