eric-maynard commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1858978770
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PrincipalSecretsGenerator.java:
##########
@@ -82,4 +86,28 @@ static PrincipalSecretsGenerator bootstrap(String realmName,
Function<String, St
}
};
}
+
+ /** Return true if environment variables for client ID & secret are set */
+ static boolean hasCredentialVariables(String realmName, String
principalName) {
Review Comment:
The issue is that the check against `POLARIS_BOOTSTRAP_%s_%s_CLIENT_SECRET`
was buried inside `bootstrap`. One potential fix could be to sort of refactor
`PrincipalSecretsGenerator` so that we have multiple implementations /
providers and we could then use the type of the `PrincipalSecretsGenerator` to
determine whether the credentials are user-provided or generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
