dimas-b commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1860879997
##########
polaris-core/src/test/java/org/apache/polaris/core/persistence/PrincipalSecretsGeneratorTest.java:
##########
@@ -18,41 +18,34 @@
*/
package org.apache.polaris.core.persistence;
-import static
org.apache.polaris.core.persistence.PrincipalSecretsGenerator.bootstrap;
-import static org.assertj.core.api.Assertions.assertThat;
-
-import java.util.Map;
-import org.apache.polaris.core.entity.PolarisPrincipalSecrets;
-import org.junit.jupiter.api.Test;
-
class PrincipalSecretsGeneratorTest {
-
- @Test
- void testRandomSecrets() {
- PolarisPrincipalSecrets s = bootstrap("test", (name) ->
null).produceSecrets("name1", 123);
- assertThat(s).isNotNull();
- assertThat(s.getPrincipalId()).isEqualTo(123);
- assertThat(s.getPrincipalClientId()).isNotNull();
- assertThat(s.getMainSecret()).isNotNull();
- assertThat(s.getSecondarySecret()).isNotNull();
- }
-
- @Test
- void testSecretOverride() {
- PrincipalSecretsGenerator gen =
- bootstrap(
- "test-Realm",
- Map.of(
- "POLARIS_BOOTSTRAP_TEST-REALM_USER1_CLIENT_ID",
- "client1",
- "POLARIS_BOOTSTRAP_TEST-REALM_USER1_CLIENT_SECRET",
- "sec2")
- ::get);
- PolarisPrincipalSecrets s = gen.produceSecrets("user1", 123);
- assertThat(s).isNotNull();
- assertThat(s.getPrincipalId()).isEqualTo(123);
- assertThat(s.getPrincipalClientId()).isEqualTo("client1");
- assertThat(s.getMainSecret()).isEqualTo("sec2");
- assertThat(s.getSecondarySecret()).isEqualTo("sec2");
- }
+ //
+ // @Test
+ // void testRandomSecrets() {
Review Comment:
Did you mean to move test code into new classes matching new implementations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
