collado-mike commented on code in PR #493:
URL: https://github.com/apache/polaris/pull/493#discussion_r1866693732
##########
polaris-service/src/main/java/org/apache/polaris/service/config/PolarisApplicationConfig.java:
##########
@@ -193,15 +348,15 @@ public long getMaxRequestBodyBytes() {
return maxRequestBodyBytes;
}
- public PolarisConfigurationStore getConfigurationStore() {
+ private PolarisConfigurationStore getConfigurationStore() {
Review Comment:
yeah, I'll rename to be more clear
However, the factory is registered as a singleton, so the factory method is
only invoked once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
