collado-mike commented on code in PR #493:
URL: https://github.com/apache/polaris/pull/493#discussion_r1866697741
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisEntityManager.java:
##########
@@ -51,11 +51,14 @@ public class PolarisEntityManager {
/**
* @param metaStoreManager the metastore manager for the current realm
* @param credentialCache the storage credential cache for the current realm
+ * @param entityCache the entity cache
*/
public PolarisEntityManager(
- PolarisMetaStoreManager metaStoreManager, StorageCredentialCache
credentialCache) {
+ PolarisMetaStoreManager metaStoreManager,
Review Comment:
That would effectively eliminate the need for `RealmEntityManagerFactory` -
which is fine, but it means the callers need to be made either realm-scoped or
request-scoped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
