snazy commented on code in PR #493:
URL: https://github.com/apache/polaris/pull/493#discussion_r1867282647
##########
polaris-service/src/main/java/org/apache/polaris/service/BootstrapRealmsCommand.java:
##########
@@ -48,17 +46,11 @@ protected void run(
Bootstrap<PolarisApplicationConfig> bootstrap,
Namespace namespace,
PolarisApplicationConfig configuration) {
- MetaStoreManagerFactory metaStoreManagerFactory =
configuration.getMetaStoreManagerFactory();
+ MetaStoreManagerFactory metaStoreManagerFactory =
Review Comment:
But that means that there's a third (CDI, Jackson, manual) way to get those
instances. I think, CDI should be used everywhere (except for very specific
tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
