flyrain commented on code in PR #495:
URL: https://github.com/apache/polaris/pull/495#discussion_r1868238124
##########
build-logic/src/main/kotlin/LicenseFileValidation.kt:
##########
@@ -58,7 +58,7 @@ class LicenseFileValidation : DependencyFilter {
override fun filter(data: ProjectData?): ProjectData {
data!!
- val rootLicenseFile = data.project.rootProject.file("LICENSE").readText()
+ val rootLicenseFile =
data.project.rootProject.file("LICENSE.bin").readText()
Review Comment:
This PR creates a new license file. Do we need two license files. I think
the one including the dependencies license is good enough.
##########
build-logic/src/main/kotlin/LicenseFileValidation.kt:
##########
@@ -58,7 +58,7 @@ class LicenseFileValidation : DependencyFilter {
override fun filter(data: ProjectData?): ProjectData {
data!!
- val rootLicenseFile = data.project.rootProject.file("LICENSE").readText()
+ val rootLicenseFile =
data.project.rootProject.file("LICENSE.bin").readText()
Review Comment:
This PR creates a new license file. Do we need two license files? I think
the one including the dependencies license is good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
