snazy commented on code in PR #495:
URL: https://github.com/apache/polaris/pull/495#discussion_r1886865907
##########
dropwizard/service/build.gradle.kts:
##########
@@ -183,4 +183,13 @@ tasks.register<Sync>("prepareDockerDist") {
tasks.named("build").configure { dependsOn("prepareDockerDist") }
+distributions {
Review Comment:
Hm - it looks like none of the dist(s) actually works.
```
./gradlew :polaris-dropwizard-service:assembleDist
```
generates TWO sets of distributions:
```
$ ls -1 dropwizard/service/build/distributions/
polaris-dropwizard-service-1.0.0-incubating-SNAPSHOT-license-report.zip
polaris-dropwizard-service-1.0.0-incubating-SNAPSHOT.tar
polaris-dropwizard-service-1.0.0-incubating-SNAPSHOT.zip
polaris-dropwizard-service-shadow-1.0.0-incubating-SNAPSHOT.tar
polaris-dropwizard-service-shadow-1.0.0-incubating-SNAPSHOT.zip
```
The "non shadow" one has the NOTICE & LICENSE files, but running
`polaris-dropwizard-service-1.0.0-incubating-SNAPSHOT/bin/polaris-service`
leads to
```
Error: Could not find or load main class
org.apache.polaris.service.dropwizard.PolarisApplication
Caused by: java.lang.ClassNotFoundException:
org.apache.polaris.service.dropwizard.PolarisApplication
```
The "shadow" does not have the NOTICE + LICENSE files, but running
`polaris-dropwizard-service-shadow-1.0.0-incubating-SNAPSHOT/bin/polaris-dropwizard-service`
does something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
