collado-mike commented on code in PR #493:
URL: https://github.com/apache/polaris/pull/493#discussion_r1870184151
##########
polaris-service/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java:
##########
@@ -35,9 +35,10 @@
import org.apache.polaris.core.persistence.PolarisTreeMapMetaStoreSessionImpl;
import org.apache.polaris.core.persistence.PolarisTreeMapStore;
-@JsonTypeName("in-memory")
+@Named("in-memory")
+@Singleton
Review Comment:
`@ApplicationScoped` is not part of the jakarta inject-api (it's in the
enterprise package), so isn't supported by Dropwizard/HK2 today. I'm fine to
remove this annotation and keep the scope defined in the configuration, but
bringing in the jakarta enterprise-inject-api is a lot more work and I think we
should keep this PR scoped
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
