collado-mike commented on code in PR #493:
URL: https://github.com/apache/polaris/pull/493#discussion_r1870378552
##########
polaris-service/src/main/java/org/apache/polaris/service/config/RealmEntityManagerFactory.java:
##########
@@ -18,29 +18,39 @@
*/
package org.apache.polaris.service.config;
+import jakarta.inject.Inject;
+import jakarta.inject.Provider;
+import java.util.HashMap;
import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
import org.apache.polaris.core.context.RealmContext;
+import org.apache.polaris.core.context.RealmScope;
import org.apache.polaris.core.persistence.MetaStoreManagerFactory;
import org.apache.polaris.core.persistence.PolarisEntityManager;
+import org.apache.polaris.core.persistence.cache.EntityCache;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/** Gets or creates PolarisEntityManager instances based on config values and
RealmContext. */
+@RealmScope
public class RealmEntityManagerFactory {
Review Comment:
You're right. I'd actually like to get rid of this, as I don't think it adds
much with the CDI infra, but I'll keep it as a singleton for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
