collado-mike commented on code in PR #493:
URL: https://github.com/apache/polaris/pull/493#discussion_r1873730287
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisEntityManager.java:
##########
@@ -51,11 +51,14 @@ public class PolarisEntityManager {
/**
* @param metaStoreManager the metastore manager for the current realm
* @param credentialCache the storage credential cache for the current realm
+ * @param entityCache the entity cache
*/
public PolarisEntityManager(
- PolarisMetaStoreManager metaStoreManager, StorageCredentialCache
credentialCache) {
+ PolarisMetaStoreManager metaStoreManager,
Review Comment:
IMO, the `PolarisEntityManager` is really just a factory for the `Resolver`
now. That whole process is something I think should be a lower-level concern,
hidden under the higher level interfaces. We've discussed a "unit of work"
approach before and I think that would be a good layer to encapsulate the
`Resolver` work. At that point, there is no need for the `PolarisEntityManager`
and the `Resolver` itself would be managed by the CDI container, but hidden
from application logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
