MonkeyCanCode opened a new pull request, #545:
URL: https://github.com/apache/polaris/pull/545

   # Description
   
   While trying to run regtest on local with Python 3.13, it failed on 
installing `pydantic-core`:
   ```
   ➜ regtests/run.sh
   ...
   Package operations: 8 installs, 1 update, 0 removals
   
     • Updating platformdirs (3.11.0 -> 4.2.2)
     • Installing pydantic-core (2.18.4): Failed
   
     ChefBuildError
   
     Backend subprocess exited when trying to invoke build_wheel
   
     Running `maturin pep517 build-wheel -i 
/private/var/folders/fl/1gq302cn7dd_w8mx24s7zhq40000gn/T/tmponjgdrat/.venv/bin/python
 --compatibility off`
     💥 maturin failed
       Caused by: Cargo metadata failed. Do you have cargo in your PATH?
       Caused by: No such file or directory (os error 2)
     Error: command ['maturin', 'pep517', 'build-wheel', '-i', 
'/private/var/folders/fl/1gq302cn7dd_w8mx24s7zhq40000gn/T/tmponjgdrat/.venv/bin/python',
 '--compatibility', 'off'] returned non-zero exit status 1
   
   
     at 
~/polaris-venv/lib/python3.13/site-packages/poetry/installation/chef.py:147 in 
_prepare
         143│
         144│                 error = ChefBuildError("\n\n".join(message_parts))
         145│
         146│             if error is not None:
       → 147│                 raise error from None
         148│
         149│             return path
         150│
         151│     def _prepare_sdist(self, archive: Path, destination: Path | 
None = None) -> Path:
   
   Note: This error originates from the build backend, and is likely not a 
problem with poetry but with pydantic-core (2.18.4) not supporting PEP 517 
builds. You can verify this by running 'pip wheel --use-pep517 "pydantic-core 
(==2.18.4)"'.
   ...
   Thu Dec 12 22:46:15 CST 2024: Starting pytest t_cli:test_cli.py
   /Users/yong/polaris-venv/bin/python3: No module named pytest
   ...
   Thu Dec 12 22:46:15 CST 2024: Test FAILED: t_cli:test_cli.py
   ...
   ```
   This then prevents the installation of `pytest` which then fails all tests 
that are based on `pytest`.
   
   Also, `regtests/t_cli/src/test_cli.py` set default polaris host to `polaris` 
which can be problematic (as we are not documenting extra set for setting 
hostname anywhere for running test on local. Thus, better to set this to 
`localhost` instead.
   
   ## Type of change
   
   Please delete options that are not relevant.
   
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Documentation update
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] This change requires a documentation update
   
   # How Has This Been Tested?
   
   Changes summary:
   1. Update doc for inform users Polaris server should be start before local 
test can be run
   2. Bump the version of `tox` from `>=3.9.0` to `>=4.19.0` as that is the 
first version that support Python 3.13
   3. Locked the version of `platformdirs` to `4.3.6` as `virtualenv` has 
`>=3.9.1,<5` and will try to downgrade version to `3.11.0` during rerun of 
local test
   
   Test results:
   ```
   # local test
   ➜ regtests/run.sh
   ...
   ==================================================================== 223 
passed, 14 skipped in 37.69s 
====================================================================
   Thu Dec 12 23:24:31 CST 2024: Test SUCCEEDED: 
t_pyspark:test_spark_sql_s3_with_privileges.py
   Thu Dec 12 23:24:31 CST 2024: Azure tests not enabled, skip running test 
t_spark_sql/src/spark_sql_azure_dfs.sh
   Thu Dec 12 23:24:31 CST 2024: GCS tests not enabled, skip running test 
t_spark_sql/src/spark_sql_gcp.sh
   Thu Dec 12 23:24:31 CST 2024: Azure tests not enabled, skip running test 
t_spark_sql/src/spark_sql_azure_blob.sh
   Thu Dec 12 23:24:31 CST 2024: Starting test t_spark_sql:spark_sql_views.sh
   Thu Dec 12 23:24:43 CST 2024: Test run concluded for 
t_spark_sql:spark_sql_views.sh
   Thu Dec 12 23:24:43 CST 2024: Test SUCCEEDED: t_spark_sql:spark_sql_views.sh
   Thu Dec 12 23:24:43 CST 2024: AWS tests not enabled, skip running test 
t_spark_sql/src/spark_sql_s3.sh
   Thu Dec 12 23:24:43 CST 2024: AWS cross region tests not enabled, skip 
running test t_spark_sql/src/spark_sql_s3_cross_region.sh
   Thu Dec 12 23:24:43 CST 2024: Starting test t_spark_sql:spark_sql_basic.sh
   Thu Dec 12 23:24:54 CST 2024: Test run concluded for 
t_spark_sql:spark_sql_basic.sh
   Thu Dec 12 23:24:54 CST 2024: Test SUCCEEDED: t_spark_sql:spark_sql_basic.sh
   Thu Dec 12 23:24:54 CST 2024: Tests completed with 3 successes and 0 failures
   
   # docker test
   ...
   regtest-1  | Fri 13 Dec 2024 05:32:48 AM UTC: Test SUCCEEDED: 
t_spark_sql:spark_sql_views.sh
   regtest-1  | Fri 13 Dec 2024 05:32:48 AM UTC: Azure tests not enabled, skip 
running test t_spark_sql/src/spark_sql_azure_dfs.sh
   regtest-1  | Fri 13 Dec 2024 05:32:48 AM UTC: Tests completed with 3 
successes and 0 failures
   regtest-1 exited with code 0
   ```
   
   # Checklist:
   
   Please delete options that are not relevant.
   
   - [x] I have performed a self-review of my code
   - [ ] I have commented my code, particularly in hard-to-understand areas
   - [ ] I have made corresponding changes to the documentation
   - [x] My changes generate no new warnings
   - [ ] If adding new functionality, I have discussed my implementation with 
the community using the linked GitHub issue
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to