adutra commented on PR #545: URL: https://github.com/apache/polaris/pull/545#issuecomment-2586690664
@MonkeyCanCode from a first glance, I note that the original ask in #21 was to move the tests to pytests, but your PR has actually 3 (unrelated?) changes: 1. Upgrade to python 3.13 2. Fix running tests locally 3. Move to pytests Would it be possible to split this PR in 3? In particular I'm worried about the complete redesign of the dockerfile. Also, the removal of `regtests/run_spark_sql.sh` seems problematic to me: it's used to run Spark locally for adhoc testing against a local running Polaris server: https://github.com/apache/polaris/blob/9377aa731a64d6262dc7cc177d8a457d14c46f0a/regtests/README.md?plain=1#L105-L111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
