collado-mike commented on code in PR #575:
URL: https://github.com/apache/polaris/pull/575#discussion_r1890867253
##########
dropwizard/service/src/test/java/org/apache/polaris/service/dropwizard/catalog/TestUtil.java:
##########
@@ -179,4 +179,22 @@ public static RESTCatalog createSnowmanManagedCatalog(
restCatalog.initialize("polaris", propertiesBuilder.buildKeepingLast());
return restCatalog;
}
+
+ /**
+ * Asserts that the response has the expected status code, with a custom
fail message. The
+ * response entity is buffered so it can be read multiple times.
+ *
+ * @param response The response to check
+ * @param expectedStatusCode The expected status code
+ */
+ private static void assertStatusCodeWithFailMessage(Response response, int
expectedStatusCode) {
Review Comment:
I'd rename this to just `assertStatusCode` - the current name made me think
it was checking the response for an expected failure message and I was very
confused about why these calls were suddenly failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
