dennishuo commented on code in PR #575:
URL: https://github.com/apache/polaris/pull/575#discussion_r1890939366


##########
dropwizard/service/src/test/java/org/apache/polaris/service/dropwizard/catalog/TestUtil.java:
##########
@@ -179,4 +179,22 @@ public static RESTCatalog createSnowmanManagedCatalog(
     restCatalog.initialize("polaris", propertiesBuilder.buildKeepingLast());
     return restCatalog;
   }
+
+  /**
+   * Asserts that the response has the expected status code, with a custom 
fail message. The
+   * response entity is buffered so it can be read multiple times.
+   *
+   * @param response The response to check
+   * @param expectedStatusCode The expected status code
+   */
+  private static void assertStatusCodeWithFailMessage(Response response, int 
expectedStatusCode) {

Review Comment:
   +1, actually I also did a double take initially when reading this, but was 
just on the fence about whether it was just my own preconceived notions :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to