MonkeyCanCode commented on code in PR #602:
URL: https://github.com/apache/polaris/pull/602#discussion_r1900939876
##########
helm/polaris/templates/deployment.yaml:
##########
@@ -56,6 +56,10 @@ spec:
imagePullPolicy: {{ tpl .Values.toolsImage.pullPolicy . }}
command: ["jar"]
args: ["-cf", "/eclipselink-config/conf.jar", "-C", "/secret",
"persistence.xml"]
+ {{- if .Values.securityContext}}
+ securityContext:
Review Comment:
Yes, I like the purpose in https://github.com/apache/polaris/pull/601 where
we will put diff `securityContext` and `extraEnv` to avoid loading extra as
well as better control on what should be set. Also, should we update the test
case to reflect this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
