adutra commented on code in PR #602:
URL: https://github.com/apache/polaris/pull/602#discussion_r1907545413
##########
helm/polaris/templates/deployment.yaml:
##########
@@ -56,6 +56,10 @@ spec:
imagePullPolicy: {{ tpl .Values.toolsImage.pullPolicy . }}
command: ["jar"]
args: ["-cf", "/eclipselink-config/conf.jar", "-C", "/secret",
"persistence.xml"]
+ {{- if .Values.securityContext}}
+ securityContext:
Review Comment:
Folks, just FYI, I am working on a complete overhaul of the helm chart in
preparation for the Quarkus switch.
**It's not ready for review yet** but if you want a sneak peek. check out
#626 and review *the last commit only*.
The TLDR is: for me, this bootstrap job needs to go away. It's not the best
way to bootstrap realms, because you need to redeploy Polaris if you want to
bootstrap a new realm. Instead, we will have a tool to execute maintenance
tasks on the Polaris database directly (see #605). This tool can be executed at
any time. IMHO that's the best solution for this. But I'm open for discussion
on this topic. In my PR #626 the bootstrap job is still present.
In the meantime, @Gerrit-K I don't think it's a good idea to work on the
current Helm chart. Let's resume this conversation once the Helm chart is
adapted to Quarkus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
