dimas-b commented on code in PR #701:
URL: https://github.com/apache/polaris/pull/701#discussion_r1911884274
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisCredentialProperty.java:
##########
@@ -41,7 +41,12 @@ public enum PolarisCredentialProperty {
"the azure storage account host",
"the azure account name + endpoint that will append to the
ADLS_SAS_TOKEN_PREFIX"),
EXPIRATION_TIME(
- Long.class, "expiration-time", "the expiration time for the access
token, in milliseconds");
+ Long.class, "expiration-time", "the expiration time for the access
token, in milliseconds"),
+ ADDITIONAL_STORAGE_CONFIG(
+ String.class,
+ "additional-storage-config",
+ "the additional storage config for the cloud storage"),
Review Comment:
Sorry, I misunderstood the intent of this PR.
I'm not sure about exposing general FileIO properties for users to configure
the _internal_ Polaris access path to table storage. Polaris may not always use
Iceberg FileIO for its internal access, but if general properties are exposes,
refactoring that area will be much harder.
@XJDKC : Would you be able to share some more details about your intended
use case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
