dimas-b commented on code in PR #701:
URL: https://github.com/apache/polaris/pull/701#discussion_r1913919435
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/PolarisCredentialProperty.java:
##########
@@ -41,7 +41,12 @@ public enum PolarisCredentialProperty {
"the azure storage account host",
"the azure account name + endpoint that will append to the
ADLS_SAS_TOKEN_PREFIX"),
EXPIRATION_TIME(
- Long.class, "expiration-time", "the expiration time for the access
token, in milliseconds");
+ Long.class, "expiration-time", "the expiration time for the access
token, in milliseconds"),
+ ADDITIONAL_STORAGE_CONFIG(
+ String.class,
+ "additional-storage-config",
+ "the additional storage config for the cloud storage"),
Review Comment:
Thanks for the explanation, @XJDKC !
The use case makes total sense from my POV. However, I'm still not sure
about overloading credential properties with this information.
Do you think a larger refactoring could be beneficial to allow customizing
storage access inside Polaris, without affecting credentials specifically?
Perhaps with such a refactoring having to excluding the new information from
REST client responses will not be necessary... WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
