adutra commented on code in PR #741:
URL: https://github.com/apache/polaris/pull/741#discussion_r1914755084
##########
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/metrics/QuarkusValueExpressionResolver.java:
##########
@@ -22,16 +22,16 @@
import io.micrometer.common.lang.Nullable;
import jakarta.annotation.Nonnull;
import jakarta.enterprise.context.ApplicationScoped;
-import org.apache.polaris.core.context.RealmContext;
+import org.apache.polaris.core.context.RealmId;
@ApplicationScoped
public class QuarkusValueExpressionResolver implements ValueExpressionResolver
{
@Override
public String resolve(@Nonnull String expression, @Nullable Object
parameter) {
// TODO maybe replace with CEL of some expression engine and make this
more generic
- if (parameter instanceof RealmContext realmContext &&
expression.equals("realmIdentifier")) {
- return realmContext.getRealmIdentifier();
+ if (parameter instanceof RealmId realmId &&
expression.equals("realmIdentifier")) {
Review Comment:
This class exists only because the old `RealmContext` did not have a
meaningful `toString()` representation.
When this class is passed as a method argument to a generated API method:
```java
@Context @MeterTag(key="realm_id",expression="realmIdentifier") RealmContext
realmContext
```
I had to use an expression + expression resolver in order to extract the id
from `RealmContext`.
Question: is it possible for `RealmId` to have a custom `toString()`
representation that simply returns the realm ID? In this case we can get rid of
the expression + resolver.
##########
helm/polaris/README.md:
##########
@@ -99,7 +99,7 @@ $ helm uninstall --namespace polaris polaris
| podAnnotations | object | `{}` | Annotations to apply to polaris pods. |
| podLabels | object | `{}` | Additional Labels to apply to polaris pods. |
| podSecurityContext | object | `{}` | Security context for the polaris pod.
See https://kubernetes.io/docs/tasks/configure-pod-container/security-context/.
|
-| polarisServerConfig | object |
`{"authenticator":{"class":"org.apache.polaris.service.auth.TestInlineBearerTokenPolarisAuthenticator"},"callContextResolver":{"type":"default"},"cors":{"allowed-credentials":true,"allowed-headers":["*"],"allowed-methods":["PATCH","POST","DELETE","GET","PUT"],"allowed-origins":["http://localhost:8080"],"allowed-timing-origins":["http://localhost:8080"],"exposed-headers":["*"],"preflight-max-age":600},"defaultRealms":["default-realm"],"featureConfiguration":{"ENFORCE_PRINCIPAL_CREDENTIAL_ROTATION_REQUIRED_CHECKING":false,"SUPPORTED_CATALOG_STORAGE_TYPES":["S3","GCS","AZURE","FILE"]},"io":{"factoryType":"default"},"logging":{"appenders":[{"logFormat":"%-5p
[%d{ISO8601} - %-6r] [%t]
[%X{aid}%X{sid}%X{tid}%X{wid}%X{oid}%X{srv}%X{job}%X{rid}] %c{30}: %m
%kvp%n%ex","threshold":"ALL","type":"console"}],"level":"INFO","loggers":{"org.apache.iceberg.rest":"DEBUG","org.apache.polaris":"DEBUG"}},"maxRequestBodyBytes":-1,"metaStoreManager":{"type":"in-memory"},"
oauth2":{"type":"test"},"rateLimiter":{"type":"no-op"},"realmContextResolver":{"type":"default"},"server":{"adminConnectors":[{"port":8182,"type":"http"}],"applicationConnectors":[{"port":8181,"type":"http"}],"maxThreads":200,"minThreads":10,"requestLog":{"appenders":[{"type":"console"}]}}}`
| Configures for polaris-server.yml |
+| polarisServerConfig | object |
`{"authenticator":{"class":"org.apache.polaris.service.auth.TestInlineBearerTokenPolarisAuthenticator"},"callContextResolver":{"type":"default"},"cors":{"allowed-credentials":true,"allowed-headers":["*"],"allowed-methods":["PATCH","POST","DELETE","GET","PUT"],"allowed-origins":["http://localhost:8080"],"allowed-timing-origins":["http://localhost:8080"],"exposed-headers":["*"],"preflight-max-age":600},"defaultRealms":["default-realm"],"featureConfiguration":{"ENFORCE_PRINCIPAL_CREDENTIAL_ROTATION_REQUIRED_CHECKING":false,"SUPPORTED_CATALOG_STORAGE_TYPES":["S3","GCS","AZURE","FILE"]},"io":{"factoryType":"default"},"logging":{"appenders":[{"logFormat":"%-5p
[%d{ISO8601} - %-6r] [%t]
[%X{aid}%X{sid}%X{tid}%X{wid}%X{oid}%X{srv}%X{job}%X{rid}] %c{30}: %m
%kvp%n%ex","threshold":"ALL","type":"console"}],"level":"INFO","loggers":{"org.apache.iceberg.rest":"DEBUG","org.apache.polaris":"DEBUG"}},"maxRequestBodyBytes":-1,"metaStoreManager":{"type":"in-memory"},"
oauth2":{"type":"test"},"rateLimiter":{"type":"no-op"},"realmIdResolver":{"type":"default"},"server":{"adminConnectors":[{"port":8182,"type":"http"}],"applicationConnectors":[{"port":8181,"type":"http"}],"maxThreads":200,"minThreads":10,"requestLog":{"appenders":[{"type":"console"}]}}}`
| Configures for polaris-server.yml |
Review Comment:
FYI the Helm chart is out of sync until #626 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
