dimas-b commented on code in PR #610:
URL: https://github.com/apache/polaris/pull/610#discussion_r1914886011
##########
quarkus/service/src/main/resources/application.properties:
##########
@@ -82,7 +82,9 @@
polaris.features.defaults."SUPPORTED_CATALOG_STORAGE_TYPES"=["S3","GCS","AZURE",
#
polaris.features.realm-overrides."my-realm"."INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST"=true
#
polaris.features.realm-overrides."my-realm"."SKIP_CREDENTIAL_SUBSCOPING_INDIRECTION"=true
-polaris.persistence.type=in-memory
+polaris.persistence.type=eclipse-link
Review Comment:
Not sure about using `eclipse-link` by default. We can always set it in Helm
values, but running from the jar locally and having to override it back to
in-memory (most of the time) seems inconvenient.
##########
build.gradle.kts:
##########
@@ -109,6 +109,7 @@ tasks.named<RatTask>("rat").configure {
excludes.add("regtests/metastore_db/**")
excludes.add("regtests/client/python/.openapi-generator/**")
excludes.add("regtests/output/**")
+ excludes.add("regtests/docker-compose.override.yml")
Review Comment:
Is it possible to keep the overrides in the build directory? I believe one
can use multiple `-f` options with `docker compose`.
##########
extension/persistence/eclipselink/build.gradle.kts:
##########
@@ -65,6 +65,10 @@ dependencies {
compileOnly("com.fasterxml.jackson.core:jackson-annotations")
compileOnly("com.fasterxml.jackson.core:jackson-core")
+ // JDBC Drivers
+ runtimeOnly(libs.h2)
Review Comment:
Is it worth keeping H2 in released runtime by default? For local runs it is
probably not much different from in-memory, and for real deployments it is not
possible to scale Polaris horizontally with H2. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
