adutra commented on code in PR #610:
URL: https://github.com/apache/polaris/pull/610#discussion_r1914931119
##########
extension/persistence/eclipselink/build.gradle.kts:
##########
@@ -65,6 +65,10 @@ dependencies {
compileOnly("com.fasterxml.jackson.core:jackson-annotations")
compileOnly("com.fasterxml.jackson.core:jackson-core")
+ // JDBC Drivers
+ runtimeOnly(libs.h2)
Review Comment:
So, I kept H2 for now because I also changed the default persistence type to
`eclipse-link`. I think we need to achieve 2 goals here:
1. The default configuration should be as "production-ready" as possible
2. The default configuration should make Polaris start successfully.
The 2 goals are sometimes in conflict. I think that by switching to
`eclipse-link` by default we achieve goal 1), and by using H2 by default, we
achieve 2) – even if H2 is not really "production ready", that's the best we
can do.
In any case, the `in-memory` persistence type imho should now be reserved
only for tests. We could (should?) even rename it to `test`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
