dennishuo commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1917573828
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1627,6 +1627,12 @@ private FileIO refreshIOWithCredentials(
// the credentials should always override table-level properties, since
// storage configuration will be found at whatever entity defines it
tableProperties.putAll(credentialsMap);
+
+ // Populate the internal properties to FileIO in case the FileIO
implementation needs them
+ Map<String, String> internalProperties =
+
storageInfoEntity.map(PolarisEntity::getInternalPropertiesAsMap).orElse(Map.of());
Review Comment:
I guess my suggestion is basically just apossible formulation of what
@dimas-b was talking about -- adding a translation layer even if we might
happen to use a "trivial" translation in some early use cases. So, +1 to having
that layer -- in this case we can make it clear that the `FileIOFactory`
extension provided by custom service-owners is what is responsible for the
interpretation here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
