XJDKC commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1917609853
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1627,6 +1627,12 @@ private FileIO refreshIOWithCredentials(
// the credentials should always override table-level properties, since
// storage configuration will be found at whatever entity defines it
tableProperties.putAll(credentialsMap);
+
+ // Populate the internal properties to FileIO in case the FileIO
implementation needs them
+ Map<String, String> internalProperties =
+
storageInfoEntity.map(PolarisEntity::getInternalPropertiesAsMap).orElse(Map.of());
Review Comment:
Another similar approach could be to store the `PolarisResolvedPathWrapper`
in `CallContext::contextVariables`. By doing so, we might avoid the need to
pass it explicitly to FileIOFactory.
Since contextVariables already contains the catalog instance, it seems like
a natural fit for encapsulating additional contextual data like
`PolarisResolvedPathWrapper`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
