snazy commented on PR #741: URL: https://github.com/apache/polaris/pull/741#issuecomment-2594782133
> Please don’t merge a PR if there are open comments. It’s important to work through all feedback, especially for something as impactful as a breaking change. Plus this isn’t an urgent fix, and just filed 2 days ago, we should take the time to think it through carefully before merging. @flyrain @jbonofre The PR got two approvals. The comment with the approval from @collado-mike answering your question: "_This seems innocuous enough. My main concern would be if application users suddenly didn't see the keys they were looking for in the logs or the headers suddenly stopped working, bug AFAICT, there are no such changes_" (emphasis mine) BTW: This `RealmId` is _still_ an interface - so I do not understand why this could not be extended. The documentation did and still clearly states that this type is used to identify the realm from a REST request - and from a REST request all you have is the ID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
