sfc-gh-ygu commented on PR #741: URL: https://github.com/apache/polaris/pull/741#issuecomment-2597459813
> no non resolved discussions (before the merge) @jbonofre This comment wasn't resolved before the merge, https://github.com/apache/polaris/pull/741#discussion_r1915722165. @snazy, we don’t really need an interface for an ID. An ID is just a string, which I see as an atomic concept—simple and self-contained, without properties. Adding sub-properties to an ID interface (e.g., `RealmId`) feels conceptually incorrect and somewhat counterintuitive. Given this, I believe names like `RealmContext` or `Realm` are much more fitting for the interface, as they better reflect the broader context or functionality it represents. This assumes we need an interface here. For any use case just requiring an id, we could use a string type instead of an interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
