adutra commented on code in PR #610:
URL: https://github.com/apache/polaris/pull/610#discussion_r1918073530
##########
quarkus/admin/build.gradle.kts:
##########
@@ -35,6 +35,7 @@ dependencies {
implementation(project(":polaris-api-iceberg-service"))
implementation(project(":polaris-service-common"))
implementation(project(":polaris-quarkus-service"))
+ runtimeOnly(project(":polaris-eclipselink"))
Review Comment:
No, it's needed because all the dependencies we need must be included _in
the build_: you cannot add this dependency when deploying Polaris. Even if the
default metastore was `foo`, if we want to support the `eclipse-link`
metastore, all the eclipselink dependencies must be included in the final
artifact (and those of `foo`).
Maybe the comparison with Nessie could help here: Nessie supports H2,
Postgres, MySQL, MariaDB, Cassandra, MongoDB, DynamoDB, and BigTable.
Therefore, all the drivers for these backends are included in Nessie builds.
Granted, this increases the artifact size, but on the other hand, the artifact
"just works" for everybody. And to be honest, Java applications have never been
famous for their small sizes :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
