eric-maynard commented on code in PR #610:
URL: https://github.com/apache/polaris/pull/610#discussion_r1918971237


##########
quarkus/admin/build.gradle.kts:
##########
@@ -35,6 +35,7 @@ dependencies {
   implementation(project(":polaris-api-iceberg-service"))
   implementation(project(":polaris-service-common"))
   implementation(project(":polaris-quarkus-service"))
+  runtimeOnly(project(":polaris-eclipselink"))

Review Comment:
   > if we want to support the eclipse-link metastore, all the eclipselink 
dependencies must be included in the final artifact
   
   Previously, it was my understanding that we asked users to supply additional 
dependencies as command-line arguments.
   
   > Nessie supports H2, Postgres, MySQL, ...
   
   By supporting EclipseLink, Polaris supports innumerable databases. Surely we 
won't include them all here? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to