jbonofre commented on code in PR #610:
URL: https://github.com/apache/polaris/pull/610#discussion_r1920526964
##########
quarkus/admin/build.gradle.kts:
##########
@@ -35,6 +35,7 @@ dependencies {
implementation(project(":polaris-api-iceberg-service"))
implementation(project(":polaris-service-common"))
implementation(project(":polaris-quarkus-service"))
+ runtimeOnly(project(":polaris-eclipselink"))
Review Comment:
@eric-maynard yes and no 😄 Quarkus does the scanning at build time, that's
true. It's the fastest and easiest way. It's possible to load a dependencies
wrap to be loaded at runtime (with Extension/Qualifier and creating the jandex
index, etc) but it requires additional hook (like custom URLClassLoader, e.g.
Quarkus community is discussing about "extended" classloader manager
https://github.com/quarkusio/quarkus/discussions/43749).
For now, I suggest to keep the "regular" and simple approach as @adutra
proposed. We can improve the loading later (with meta extension/classloader
manager).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
