dimas-b commented on code in PR #610:
URL: https://github.com/apache/polaris/pull/610#discussion_r1922800236
##########
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##########
@@ -181,6 +182,10 @@ public void maybeInitializeInMemoryRealm(
MetaStoreManagerFactory factory,
RealmContextConfiguration realmContextConfiguration) {
if (factory instanceof InMemoryPolarisMetaStoreManagerFactory) {
+ LoggerFactory.getLogger(QuarkusProducers.class)
+ .warn(
+ "Polaris is configured with an in-memory metastore; "
Review Comment:
nit: maybe move to a separate PR for clarity?
##########
gradle/libs.versions.toml:
##########
@@ -81,6 +81,7 @@ opentelemetry-bom = { module =
"io.opentelemetry:opentelemetry-bom", version = "
opentelemetry-semconv = { module =
"io.opentelemetry.semconv:opentelemetry-semconv", version = "1.25.0-alpha" }
picocli = { module = "info.picocli:picocli-codegen", version.ref = "picocli" }
picocli-codegen = { module = "info.picocli:picocli-codegen", version.ref =
"picocli" }
+postgresql = { module = "org.postgresql:postgresql", version = "42.7.4" }
Review Comment:
This declaration does look now (after recent review-driven changes)
##########
quarkus/admin/build.gradle.kts:
##########
@@ -35,6 +35,7 @@ dependencies {
implementation(project(":polaris-api-iceberg-service"))
implementation(project(":polaris-service-common"))
implementation(project(":polaris-quarkus-service"))
+ runtimeOnly(project(":polaris-eclipselink"))
Review Comment:
I guess this change can be in a separate PR now that the docker image does
not use EclipseLink.
##########
quarkus/service/build.gradle.kts:
##########
@@ -29,6 +29,7 @@ dependencies {
implementation(project(":polaris-api-iceberg-service"))
implementation(project(":polaris-service-common"))
implementation(project(":polaris-quarkus-defaults"))
+ runtimeOnly(project(":polaris-eclipselink"))
Review Comment:
Do we need dep in this PR now that docker runs with in-memory storage? I'd
support this dependency in general, but it does not look necessary for this
particular PR now :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
