XJDKC commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1930035899
##########
service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java:
##########
@@ -1586,27 +1525,22 @@ protected String viewName() {
}
}
- private FileIO refreshIOWithCredentials(
+ private FileIO refreshIOForTableLike(
Review Comment:
Yes, I think `refresh` here means we refresh the credential used by the
FileIO. But instead of updating the existing FileIO, we create a new one
instead since there is no such a way to updating the FileIO's properties.
I will rename the method to `loadFileIOForTableLike` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
