dimas-b commented on code in PR #724:
URL: https://github.com/apache/polaris/pull/724#discussion_r1930873247
##########
service/common/src/main/java/org/apache/polaris/service/catalog/io/WasbTranslatingFileIOFactory.java:
##########
@@ -19,19 +19,63 @@
package org.apache.polaris.service.catalog.io;
import io.smallrye.common.annotation.Identifier;
+import jakarta.annotation.Nonnull;
import jakarta.enterprise.context.ApplicationScoped;
+import jakarta.inject.Inject;
import java.util.Map;
-import org.apache.hadoop.conf.Configuration;
-import org.apache.iceberg.CatalogUtil;
+import java.util.Set;
+import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.io.FileIO;
+import org.apache.polaris.core.PolarisConfigurationStore;
+import org.apache.polaris.core.context.RealmId;
+import org.apache.polaris.core.persistence.MetaStoreManagerFactory;
+import org.apache.polaris.core.persistence.PolarisResolvedPathWrapper;
+import org.apache.polaris.core.storage.PolarisStorageActions;
+import org.apache.polaris.service.config.RealmEntityManagerFactory;
/** A {@link FileIOFactory} that translates WASB paths to ABFS ones */
@ApplicationScoped
@Identifier("wasb")
public class WasbTranslatingFileIOFactory implements FileIOFactory {
+
+ private final FileIOFactory defaultFileIOFactory;
+
+ @Inject
+ public WasbTranslatingFileIOFactory(
+ RealmEntityManagerFactory realmEntityManagerFactory,
+ MetaStoreManagerFactory metaStoreManagerFactory,
+ PolarisConfigurationStore configurationStore) {
+ defaultFileIOFactory =
+ new DefaultFileIOFactory(
Review Comment:
I guess I missed `WasbTranslatingFileIO` :sweat_smile: IMHO, wrapping an
implementation that has a specific purpose and behaviour (like
`DefaultFileIOFactory`) is not ideal. I'd prefer to extract a base class that
can be shared between `DefaultFileIOFactory` and
`WasbTranslatingFileIOFactory`... but that can be done later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
