adutra commented on code in PR #848:
URL: https://github.com/apache/polaris/pull/848#discussion_r1930508156
##########
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java:
##########
@@ -100,13 +100,8 @@ public PolarisDiagnostics polarisDiagnostics() {
@Produces
@RequestScoped
- public RealmId realmId(@Context HttpServerRequest request, RealmIdResolver
realmIdResolver) {
- return realmIdResolver.resolveRealmContext(
- request.absoluteURI(),
- request.method().name(),
- request.path(),
- request.headers().entries().stream()
- .collect(HashMap::new, (m, e) -> m.put(e.getKey(), e.getValue()),
HashMap::putAll));
+ public RealmId realmId(@Context ContainerRequestContext request) {
+ return (RealmId) request.getProperty(RealmIdFilter.REALM_ID_KEY);
Review Comment:
This is implicitly the case already: if the property is absent, this method
returns null – and returning null from a producer method is forbidden:
https://docs.jboss.org/cdi/spec/2.0/cdi-spec.html#producer_method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
