dimas-b commented on code in PR #848:
URL: https://github.com/apache/polaris/pull/848#discussion_r1941991644
##########
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/tracing/QuarkusTracingFilter.java:
##########
@@ -19,32 +19,41 @@
package org.apache.polaris.service.quarkus.tracing;
import io.opentelemetry.api.trace.Span;
-import io.quarkus.vertx.web.RouteFilter;
-import io.vertx.ext.web.RoutingContext;
+import jakarta.annotation.Priority;
import jakarta.enterprise.context.ApplicationScoped;
+import jakarta.ws.rs.container.ContainerRequestContext;
+import jakarta.ws.rs.container.ContainerRequestFilter;
+import jakarta.ws.rs.container.PreMatching;
+import jakarta.ws.rs.ext.Provider;
+import org.apache.polaris.core.context.RealmContext;
+import org.apache.polaris.service.context.RealmContextFilter;
+import org.apache.polaris.service.quarkus.config.QuarkusFilterPriorities;
import org.apache.polaris.service.quarkus.logging.QuarkusLoggingMDCFilter;
import org.eclipse.microprofile.config.inject.ConfigProperty;
+@PreMatching
@ApplicationScoped
-public class QuarkusTracingFilter {
+@Priority(QuarkusFilterPriorities.TRACING_FILTER)
+@Provider
+public class QuarkusTracingFilter implements ContainerRequestFilter {
public static final String REQUEST_ID_ATTRIBUTE = "polaris.request.id";
- public static final String REALM_ID_ATTRIBUTE = "polaris.realm";
+ public static final String REALM_ID_ATTRIBUTE = "polaris.realm.id";
@ConfigProperty(name = "quarkus.otel.sdk.disabled")
boolean sdkDisabled;
- @RouteFilter(QuarkusLoggingMDCFilter.PRIORITY - 1)
- public void applySpanAttributes(RoutingContext rc) {
+ @Override
+ public void filter(ContainerRequestContext rc) {
if (!sdkDisabled) {
Review Comment:
tangential: When OTel is disabled, it's still ok to operate on
`Span.current()`, we'd simply get a "no-op" `Span`. However, IMHO it is
preferable to exercise the code that produces span values even when tracing is
disabled. This is to avoid bugs that only pop up when tracing is on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
