dennishuo commented on PR #589: URL: https://github.com/apache/polaris/pull/589#issuecomment-2619834153
One major element of this refactor that ended up potentially counterproductive to portability is that previously, the use of `callCtx.getMetaStore() -> PolarisMetaStoreSession` insulated the business-logic layer from needing to know about `PolarisMetaStoreSession` at all when interfacing with `PolarisMetaStoreManagerImpl`. Since we want to better contain the existence of `PolarisMetaStoreSession` even more as a potentially db-specific implementation detail, we probably want *at least* some kind of other wrapper that represents RequestScoped persistence context that is also agnostic to specific persistence impls. If we do reintroduce `@RequestScoped CallContext` we can document this aspect as one of the purposes of the `CallContext`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
