eric-maynard commented on code in PR #589:
URL: https://github.com/apache/polaris/pull/589#discussion_r1934766937
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -101,25 +100,6 @@ public PolarisConfiguration<T> build() {
}
}
- /**
- * Returns the value of a `PolarisConfiguration`, or the default if it
cannot be loaded. This
- * method does not need to be used when a `CallContext` is already available
- */
- public static <T> T loadConfig(PolarisConfiguration<T> configuration) {
Review Comment:
It doesn't necessarily have to rely on thread-local, couldn't the
callcontext just have been injected in?
The caller won't always have a `RealmId` available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
