eric-maynard commented on code in PR #899:
URL: https://github.com/apache/polaris/pull/899#discussion_r1934392880
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -117,9 +116,8 @@ public synchronized Map<String, PrincipalSecretsResult>
bootstrapRealms(
@Override
public void purgeRealms(List<String> realms) {
for (String realm : realms) {
- PolarisMetaStoreManager metaStoreManager =
- getOrCreateMetaStoreManager(RealmId.newRealmId(realm));
- PolarisMetaStoreSession session =
getOrCreateSessionSupplier(RealmId.newRealmId(realm)).get();
+ PolarisMetaStoreManager metaStoreManager =
getOrCreateMetaStoreManager(Realm.fromName(realm));
+ PolarisMetaStoreSession session =
getOrCreateSessionSupplier(Realm.fromName(realm)).get();
Review Comment:
Same here -- let's try to pass around `Realm` instead of the name where
possible
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -130,44 +128,43 @@ public void purgeRealms(List<String> realms) {
}
@Override
- public synchronized PolarisMetaStoreManager
getOrCreateMetaStoreManager(RealmId realmId) {
- if (!metaStoreManagerMap.containsKey(realmId.id())) {
- initializeForRealm(realmId, null);
- checkPolarisServiceBootstrappedForRealm(realmId,
metaStoreManagerMap.get(realmId.id()));
+ public synchronized PolarisMetaStoreManager
getOrCreateMetaStoreManager(Realm realm) {
+ if (!metaStoreManagerMap.containsKey(realm.name())) {
+ initializeForRealm(realm, null);
+ checkPolarisServiceBootstrappedForRealm(realm,
metaStoreManagerMap.get(realm.name()));
}
- return metaStoreManagerMap.get(realmId.id());
+ return metaStoreManagerMap.get(realm.name());
}
@Override
- public synchronized Supplier<PolarisMetaStoreSession>
getOrCreateSessionSupplier(
- RealmId realmId) {
- if (!sessionSupplierMap.containsKey(realmId.id())) {
- initializeForRealm(realmId, null);
- checkPolarisServiceBootstrappedForRealm(realmId,
metaStoreManagerMap.get(realmId.id()));
+ public synchronized Supplier<PolarisMetaStoreSession>
getOrCreateSessionSupplier(Realm realm) {
+ if (!sessionSupplierMap.containsKey(realm.name())) {
+ initializeForRealm(realm, null);
+ checkPolarisServiceBootstrappedForRealm(realm,
metaStoreManagerMap.get(realm.name()));
} else {
- checkPolarisServiceBootstrappedForRealm(realmId,
metaStoreManagerMap.get(realmId.id()));
+ checkPolarisServiceBootstrappedForRealm(realm,
metaStoreManagerMap.get(realm.name()));
}
- return sessionSupplierMap.get(realmId.id());
+ return sessionSupplierMap.get(realm.name());
}
@Override
- public synchronized StorageCredentialCache
getOrCreateStorageCredentialCache(RealmId realmId) {
- if (!storageCredentialCacheMap.containsKey(realmId.id())) {
+ public synchronized StorageCredentialCache
getOrCreateStorageCredentialCache(Realm realm) {
+ if (!storageCredentialCacheMap.containsKey(realm.name())) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
