flyrain commented on code in PR #899:
URL: https://github.com/apache/polaris/pull/899#discussion_r1934532764
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -117,9 +116,8 @@ public synchronized Map<String, PrincipalSecretsResult>
bootstrapRealms(
@Override
public void purgeRealms(List<String> realms) {
for (String realm : realms) {
- PolarisMetaStoreManager metaStoreManager =
- getOrCreateMetaStoreManager(RealmId.newRealmId(realm));
- PolarisMetaStoreSession session =
getOrCreateSessionSupplier(RealmId.newRealmId(realm)).get();
+ PolarisMetaStoreManager metaStoreManager =
getOrCreateMetaStoreManager(Realm.fromName(realm));
+ PolarisMetaStoreSession session =
getOrCreateSessionSupplier(Realm.fromName(realm)).get();
Review Comment:
We are actually passing a `Realm` object here. But I agreed that the code
could be more consistent. Can we defer this to the same followup refactor as
above mentioned? This may need changes the key types of several maps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
