kameshsampath opened a new issue, #981:
URL: https://github.com/apache/polaris/issues/981

   ### Is your feature request related to a problem? Please describe.
   
   Currently the `service` type does not support specifying an arbitrary 
nodePort value for the services.  Its practice with k8s deployment with Helm to 
allow specifying the `nodePort` number.
   
   ### Describe the solution you'd like
   
   The service.ports could be modified as 
   
   ```yaml
   service:
      type: ClusterIP/NodePort
      ports:
         - polaris-service
               targetPort: 8181
               nodePort: 320081 # optional nodeport 
        - polaris-metrics
              targetPort: 8182
              nodePort: 320082 # optional nodeport 
   ```
   
   Then the corresponding `service` template could be 
   
   ```yaml
   apiVersion: v1
   kind: Service
   metadata:
     name: {{ include "polaris.fullname" . }}
     namespace: {{ .Release.Namespace }}
     labels:
       {{- include "polaris.labels" . | nindent 4 }}
     {{- if .Values.service.annotations }}
     annotations:
       {{- tpl (toYaml .Values.service.annotations) . | nindent 4 }}
     {{- end }}
   spec:
     type: {{ .Values.service.type | default "ClusterIP" }}
     selector:
       {{- include "polaris.selectorLabels" . | nindent 4 }}
     ports:
       {{- range $name, $port := .Values.service.ports }}
       - name: {{ $portName }}
         port: {{ $port.targetPort }}
         targetPort: {{ $port.targetPort }}
         {{- if and (eq $.Values.service.type "NodePort") $port.nodePort }}
         nodePort: {{ $port.nodePort }}
         {{- end }}
         protocol: TCP
       {{- end }}
     sessionAffinity: {{ .Values.service.sessionAffinity }}
   
   ```
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to