adutra commented on issue #981: URL: https://github.com/apache/polaris/issues/981#issuecomment-2650722201
Hi, thanks for submitting this! In fact, adding a node port is already planned in the new Helm chart redesigned for Quarkus (#626): https://github.com/apache/polaris/blob/c64771b4edd558516c817e0faac79de2d41c0932/helm/polaris/values.yaml#L103 The corresponding template is here: https://github.com/apache/polaris/blob/ad0d4805b4ae2a0ce44e7ace80c3ae71abd041d9/helm/polaris/templates/service.yaml#L43 The only difference I see with your PR #982 is that we don't test if the service type is `NodePort`. I suggest then that we merge #626 first (I was planning to do so today anyways), then if you feel like we should enhance the templates to test the service type before printing the node port, then you could rebase your PR. Is that OK? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
