dimas-b commented on code in PR #1001:
URL: https://github.com/apache/polaris/pull/1001#discussion_r1956328195
##########
service/common/src/main/java/org/apache/polaris/service/auth/JWTBroker.java:
##########
@@ -86,10 +88,13 @@ public String getSub() {
@Override
public String getScope() {
- return decodedJWT.getClaim("scope").asString();
+ return decodedJWT.getClaim(CLAIM_KEY_SCOPE).asString();
}
};
+ } catch (TokenExpiredException e) {
+ LOGGER.error("Credentials have timed out with error", e);
+ throw new AuthenticationTimeoutException("Credentials have timed out");
Review Comment:
I do not think 419 is a correct response for expired credentials. I believe
401 (with a challenge) is appropriate in this case.
##########
service/common/src/main/java/org/apache/polaris/service/exception/PolarisStatus.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.service.exception;
+
+import jakarta.ws.rs.core.Response;
+
+public enum PolarisStatus implements Response.StatusType {
+ AUTHENTICATION_TIMEOUT(419, "Authentication Timeout"),
Review Comment:
419, as far as I can tell it is not an official error code. It is certainly
not an "Authentication Timeout".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
