flyrain commented on PR #1001: URL: https://github.com/apache/polaris/pull/1001#issuecomment-2660752448
> There were previous discussions about supporting external IdPs in Polaris. In that case it would be impossible for Polaris to provide the 419 response consistently in all cases. Therefore, I think it is preferable to keep the standard 401 response. > > Also, [apache/iceberg#12197](https://github.com/apache/iceberg/pull/12197) greatly expands Iceberg REST client's capabilities in the authentication area. After that PR, clients should be able to handle more complex authentication flows with OAuth2-based token refresh, so there will hopefully be no need for 419 responses. AFAIK, [apache/iceberg#12197](https://github.com/apache/iceberg/pull/12197) doesn't change the Iceberg REST spec to remove `419`. Or does it? Even it does, Polaris still needs to support existing clients which expect 419. Also the serious of [apache/iceberg#12197](https://github.com/apache/iceberg/pull/12197) is only for Java clients, other clients aren't covered. That said, I'm not against keeping 401 response if there are strong reasons. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
