eric-maynard commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1964864442
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/BootstrapCommand.java:
##########
@@ -43,20 +45,17 @@ static class InputOptions {
FileInputOptions fileOptions;
static class StandardInputOptions {
-
@CommandLine.Option(
- names = {"-r", "--realm"},
- paramLabel = "<realm>",
- required = true,
- description = "The name of a realm to bootstrap.")
- List<String> realms;
+ names = {"-c", "--credentials"},
+ description =
+ "Principal credentials to bootstrap. If provided, must be a
valid JSON array e.g. "
+ + "[{\"realm\": \"my-realm\", \"principal\": \"root\",
\"clientId\": \"polaris\", \"clientSecret\": \"p4ssw0rd\"}]")
+ String credentials;
@CommandLine.Option(
- names = {"-c", "--credential"},
- paramLabel = "<realm,clientId,clientSecret>",
Review Comment:
Refer to my comments and -1 on #633 for more context, but essentially I
don't think this format captures the full range of ways you might wish to
bootstrap. I also don't think we really want two syntaxes for bootstrapping.
With that being said, I'd like to understand why the [pre-Quarkus bootstrap
behavior](https://github.com/apache/polaris/pull/461#issuecomment-2666608052)
is now gone, since being able to bootstrap a realm without specifying
credentials is a core part of why this heavier syntax makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
